This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/5] Share 'enum target_hw_bp_type' in GDB and GDBserver.
- From: Tom Tromey <tromey at redhat dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: Yao Qi <yao at codesourcery dot com>, <gdb-patches at sourceware dot org>
- Date: Wed, 24 Jul 2013 08:03:48 -0600
- Subject: Re: [PATCH 1/5] Share 'enum target_hw_bp_type' in GDB and GDBserver.
- References: <1369881867-11372-1-git-send-email-yao at codesourcery dot com> <1372475427-24862-1-git-send-email-yao at codesourcery dot com> <1372475427-24862-2-git-send-email-yao at codesourcery dot com> <alpine dot DEB dot 1 dot 10 dot 1307240102350 dot 32382 at tp dot orcam dot me dot uk>
>>>>> "Maciej" == Maciej W Rozycki <macro@codesourcery.com> writes:
Maciej> On Sat, 29 Jun 2013, Yao Qi wrote:
>> 'enum target_hw_bp_type' has been used in both GDB and GDBserver. It
>> will be used in MIPS hardware watchpoint support too. This patch
>> is to share 'enum target_hw_bp_type' in common/break-common.h.
Maciej> FWIW this patch looks reasonable to me, though I can't approve
Maciej> or reject a generic change like this. I can see
Maciej> gdb/gdbserver/linux-aarch64-low.c has a similar
Maciej> target_point_type enum. It might be a good idea to unify them
Maciej> all.
This patch is ok.
Tom