This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Rely on beneath to do partial xfer from tfile target
- From: Tom Tromey <tromey at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Wed, 17 Jul 2013 13:57:23 -0600
- Subject: Re: [PATCH] Rely on beneath to do partial xfer from tfile target
- References: <1363774156-31949-1-git-send-email-yao at codesourcery dot com> <5149A022 dot 7070302 at redhat dot com> <514C291B dot 7010201 at codesourcery dot com>
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> +if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
Yao> + executable {debug nowarnings}] != "" } {
Yao> + untested read-memory.exp
Yao> + return -1
Yao> +}
Yao> +clean_restart $testfile
I think this can use prepare_for_testing.
Yao> + with_test_prefix "/wo setting traceframe" {
More normal is "w/o".
Yao> + with_test_prefix "/w setting traceframe" {
.. and "w/".
This occurs in a couple places.
The patch is ok with those fixes. Thanks.
Tom