This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v12 4/5] Function is_elf_target.
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: nicolas dot blanc at intel dot com
- Cc: gdb-patches at sourceware dot org, dje at google dot com, nicolas dot blanc at intel dot com
- Date: Wed, 17 Jul 2013 20:43:32 +0200 (CEST)
- Subject: Re: [PATCH v12 4/5] Function is_elf_target.
- References: <1374078455-906-1-git-send-email-nicolas dot blanc at intel dot com> <1374078455-906-5-git-send-email-nicolas dot blanc at intel dot com>
> From: Nicolas Blanc <nicolas.blanc@intel.com>
> Date: Wed, 17 Jul 2013 18:27:34 +0200
>
> 2013-17-07 Nicolas Blanc <nicolas.blanc@intel.com>
>
> gdb/testsuite
> * lib/gdb.exp (is_elf_target): New function.
>
> Signed-off-by: Nicolas Blanc <nicolas.blanc@intel.com>
That's a very incomplete list.
I think a better solution is needed. Instead of whitelisting targets
for what is basically the default, blacklisting targets that aren't
ELF would be a better approach.
> ---
> gdb/testsuite/lib/gdb.exp | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 376aacc..8c5cdb5 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -1782,6 +1782,21 @@ proc supports_reverse {} {
> return 0
> }
>
> +# Return 1 if target supports ELF.
> +proc is_elf_target {} {
> +
> + if { [istarget "*-*-linux*"]
> + || [istarget "*-*-gnu*"]
> + || [istarget "*-*-elf*"]
> + || [istarget "arm*-*-eabi*"]
> + || [istarget "arm*-*-symbianelf*"]
> + || [istarget "powerpc-*-eabi*"] } {
> + return 1
> + }
> +
> + return 0
> +}
> +
> # Return 1 if target is ILP32.
> # This cannot be decided simply from looking at the target string,
> # as it might depend on externally passed compiler options like -m64.
> --
> 1.7.6.5
>
>