This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/5] powerpc64-aix- Processing XLC generated line tables
- From: Tom Tromey <tromey at redhat dot com>
- To: Raunaq 12 <raunaq12 at in dot ibm dot com>
- Cc: gdb-patches at sourceware dot org, Joel Brobecker <brobecker at adacore dot com>
- Date: Wed, 10 Jul 2013 11:37:19 -0600
- Subject: Re: [PATCH 1/5] powerpc64-aix- Processing XLC generated line tables
- References: <OFCC1287F3 dot 734C3B12-ON65257BA3 dot 003677E5-65257BA3 dot 00368540 at in dot ibm dot com> <20130709144847 dot GC8063 at adacore dot com> <OF9A3EE4E4 dot 3316E009-ON65257BA4 dot 0022706B-65257BA4 dot 00236B06 at in dot ibm dot com>
>>>>> ">" == Raunaq 12 <raunaq12@in.ibm.com> writes:
>> powerpc-ibm-aix: Fix line number handling for xlc compiled binaries.
>> xlc compiled binaries have a line table which is different from gcc
>> compiled ones.
>> It does not contain 1 extra entry which indicates the function start PC.
Your patch got line-wrapped by your mailer, making it hard to read.
Also you should send a ChangeLog entry with a patch.
See the gdb contribution instructions in gdb/CONTRIBUTE.
>> + if (lineTb->item[jj].line == 0 && (lineTb->item[jj].pc !=
lineTb-> item[jj+1].pc))
I think this line is too long.
Also it is not formatted properly... no space after "->", but spaces
required around "+".
Tom