Re: [PATCH] Fix PR 15692 -dprintf-insert does not accept double quotes

[Hui Zhu <teawater at gmail dot com>]

On Wed, Jul 3, 2013 at 6:55 PM, Yao Qi <yao@codesourcery.com> wrote:
> On 07/03/2013 04:41 PM, Hui Zhu wrote:
>>
>> @@ -68,7 +68,7 @@ proc mi_continue_dprintf {args} {
>>         mi_run_cmd
>>         set msg "mi 1st dprintf"
>>         gdb_expect {
>> -            -re ".*At foo entry.*arg=1234, g=1234" {
>> +            -re ".*foobarbazqux.*At foo entry.*arg=1234, g=1234" {
>
>
> It is good if we match double quotes before and after foobarbazqux, and get
> rid of ".*" between "foobarbazqux" and "At foo entry", in order to get the
> test more restrictive.  Something like
>
>   ".*\\\\\"foobarbazqux\\\\\" At foo entry.*arg=1234, g=1234"
>
> I have no other comments then.

Update test patch for it.

Thanks,
Hui

>
> --
> Yao (éå)

2013-07-03  Hui Zhu  <hui@codesourcery.com>

	PR gdb/15692
	mi/mi-cmd-break.c (mi_argv_to_format): Handle double quotes.

2013-07-03  Hui Zhu  <hui@codesourcery.com>

	PR gdb/15692
	gdb.mi/mi-dprintf.exp: Add double quotes test.

Attachment: dprintf-mi-handle-quotes.txt
Description: Text document

Attachment: dprintf-mi-handle-quotes-test.txt
Description: Text document