This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Build regression on CentOS-5 [Re: [PATCH 3/3] add -Wold-style-definition]
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 3 Jul 2013 11:00:18 +0200
- Subject: Re: Build regression on CentOS-5 [Re: [PATCH 3/3] add -Wold-style-definition]
- References: <1371494572-26594-1-git-send-email-tromey at redhat dot com> <1371494572-26594-4-git-send-email-tromey at redhat dot com> <20130702080754 dot GA24111 at host2 dot jankratochvil dot net> <87hagcela1 dot fsf at fleche dot redhat dot com> <87a9m4el8y dot fsf at fleche dot redhat dot com>
On Tue, 02 Jul 2013 22:54:05 +0200, Tom Tromey wrote:
> @@ -1580,6 +1582,17 @@ printcmd.o: $(srcdir)/printcmd.c
> $(COMPILE.post) $(srcdir)/printcmd.c
> $(POSTCOMPILE)
>
> +# ada-exp.c can appear in srcdir, for releases; or in ., for
> +# development builds.
> +ADA_EXP_C = `if test -f ada-exp.c; then echo ada-exp.c; else echo $(srcdir)/ada-exp.c; fi`
> +
> +# Some versions of flex give output that triggers
> +# -Wold-style-definition.
> +ada-exp.o: ada-exp.c
> + $(COMPILE.pre) $(INTERNAL_CFLAGS) $(GDB_WARN_CFLAGS_NO_DEFS) \
> + $(COMPILE.post) $(ADA_EXP_C)
I would find easier: s/$(ADA_EXP_C)/$</ and remove ADA_EXP_C = above.
Or is that for non-GNU make without VPATH? But non-VPATH make would IMO fail
on missing pre-requisite file ada-exp.c.
I do not mind either way.
> + $(POSTCOMPILE)
> +
> # Message files. Based on code in gcc/Makefile.in.
>
> # Rules for generating translated message descriptions. Disabled by
Thanks,
Jan