This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 11/16] move some statics from remote_read_qxfer into struct remote_state
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 01 Jul 2013 12:05:59 -0600
- Subject: Re: [PATCH 11/16] move some statics from remote_read_qxfer into struct remote_state
- References: <1372441229-305-1-git-send-email-tromey at redhat dot com> <1372441229-305-12-git-send-email-tromey at redhat dot com> <51D1A922 dot 9090707 at redhat dot com>
>> This moves a few static variables out of remote_read_qxfer and into
>> remote_state. It is unclear to me if this data can ever be required
>> to be kept around across a potential target switch, but it is
>> definitely safe to move it into the remote state object.
Pedro> Hmm, are we still unclear about it? It seems to me that if we
Pedro> dropped the data, we'd always be able to re-fetch it, though obviously
Pedro> we'd lose on the optimization. It definitely seems to me that
Pedro> putting it in the remote state object is the correct choice.
Pedro> Maybe you're seeing something I'm not though.
Nope, I just neglected to update the note.
I've dropped everything after the first sentence.
Tom