This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi Pedro, Thanks for your review. On Wed, Jun 26, 2013 at 11:27 PM, Pedro Alves <palves@redhat.com> wrote: > On 04/19/2013 03:40 PM, Hui Zhu wrote: >> Hi, >> >> This bug is because build_target_command_list didn't reset >> bl->target_info.tcommands because bl->needs_update is 0 after change >> dprintf style. >> So Update needs_update in update_dprintf_command_list. >> >> Also I update test for it. >> >> Please help me review it. >> >> Thanks, >> Hui >> >> 2013-04-19 Hui Zhu <hui@codesourcery.com> >> >> PR gdb/15184 >> >> * breakpoint.c (update_dprintf_command_list): Set needs_update. >> >> 2013-04-19 Hui Zhu <hui@codesourcery.com> >> >> PR gdb/15184 >> >> * gdb.base/dprintf.exp: Add test for agent update. >> >> >> dprintf-update.txt >> >> >> --- a/gdb/breakpoint.c >> +++ b/gdb/breakpoint.c >> @@ -8910,6 +8910,10 @@ update_dprintf_command_list (struct brea >> { >> char *dprintf_args = b->extra_string; >> char *printf_line = NULL; >> + struct bp_location *loc = b->loc; >> + >> + for (; loc; loc = loc->next) >> + loc->needs_update = 1; >> > > Write as: > > struct bp_location *loc; > > for (loc = b->loc; loc != NULL; loc = loc->next) > loc->needs_update = 1; Fixed. > > I tried it out, and the test passes for me without the fix. > I had to manually rebase due to recent changes in dprintf.exp, > so perhaps I did something wrong. Could you send a fresh > version against current mainline, and be sure the test fails > without the fix? I think it because the dprintf.exp was updated by other patch. So it make this patch cannot OK on it. I post a new test patch that can patch to the dprintf.exp and reproduced this issue in my part. Please help me try it. Thanks, Hui > > Thanks, > -- > Pedro Alves > 2013-06-29 Hui Zhu <hui@codesourcery.com> PR gdb/15184 * breakpoint.c (update_dprintf_command_list): Set needs_update. 2013-06-29 Hui Zhu <hui@codesourcery.com> PR gdb/15184 * gdb.base/dprintf.exp: Add test for agent update.
Attachment:
dprintf-update.txt
Description: Text document
Attachment:
dprintf-update-test.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |