This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Make parser-defs.h and ax-gdb.h more self-contained
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 26 Jun 2013 12:28:06 +0100
- Subject: Re: [PATCH] Make parser-defs.h and ax-gdb.h more self-contained
- References: <m3fvw5wkzr dot fsf at redhat dot com>
On 06/26/2013 05:31 AM, Sergio Durigan Junior wrote:
> Hi,
>
> While debugging an IA-64 problem, I found that parser-defs.h and
> ax-gdb.h are not totally self-contained, i.e., they are missing some
> forward declarations or #include. This patch fixes it.
>
> For ax-gdb.h, it just adds a forward declaration for `union
> exp_element'. For parser-defs.h, it adds forward declarations to
> `struct internalvar' and `enum noside', and also #include's
> expression.h, since the header file explicitly uses `enum exp_opcode'.
Forward declarations of enums is a gcc extension. You need to include
the proper header instead. But that's expression.h, and you've
already included it, so we can just remove that enum forward declaration.
OK with that change.
--
Pedro Alves