This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] print '--with{,out}-babeltrace' in 'gdb --configuration'
- From: Doug Evans <dje at google dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: Yao Qi <yao at codesourcery dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Mon, 24 Jun 2013 11:35:31 -0700
- Subject: Re: [PATCH] print '--with{,out}-babeltrace' in 'gdb --configuration'
- References: <1365761475-23845-1-git-send-email-yao at codesourcery dot com> <CADPb22RPtCiBOg8o6M1vKXJxGeDcTOriact4ujojygskBnrFFQ at mail dot gmail dot com> <83fvyr58c5 dot fsf at gnu dot org> <CADPb22R_D10GWjkpBMag2+kDXbzCrpxjmR8UF_AZ13J6tix84g at mail dot gmail dot com> <516DEDAD dot 8070902 at codesourcery dot com> <CADPb22TtrdbFERAV_MZhvE43XVJuB25RwUgBVUwPVBEcGObLgg at mail dot gmail dot com> <516E0ED2 dot 2080203 at codesourcery dot com> <83obdd2irl dot fsf at gnu dot org> <CADPb22RcDd7LyyTL=TWpkxFS+s6hx+_xRL-_+iiWgZG0qRu=VA at mail dot gmail dot com> <83sj0al6u1 dot fsf at gnu dot org>
On Sat, Jun 22, 2013 at 4:31 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Wed, 17 Apr 2013 10:25:23 -0700
>> From: Doug Evans <dje@google.com>
>> Cc: Yao Qi <yao@codesourcery.com>, gdb-patches <gdb-patches@sourceware.org>
>>
>> On Wed, Apr 17, 2013 at 10:01 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> >> Date: Wed, 17 Apr 2013 10:54:10 +0800
>> >> From: Yao Qi <yao@codesourcery.com>
>> >> CC: Eli Zaretskii <eliz@gnu.org>, gdb-patches <gdb-patches@sourceware.org>
>> >>
>> >> The "relocatable" is unclear to me unless I checked configure.ac and
>> >> previous discussions.
>> >
>> > I will add something to explain that, assuming I will find a way to
>> > say that concisely.
>>
>> [for completeness sake]
>> I'd be ok with just adding something to the manual.
>> It would be good to document the fact that a gdb install tree can be
>> moved and gdb will still find its relocatable ancillary files.
>> This goes along with the ability to do "make install DESTDIR=/foo"
>> which is a nice capability.
>
> Is the below OK?
>
> Index: gdb/top.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/top.c,v
> retrieving revision 1.236
> diff -u -p -r1.236 top.c
> --- gdb/top.c 30 May 2013 17:27:44 -0000 1.236
> +++ gdb/top.c 22 Jun 2013 11:30:47 -0000
> @@ -1252,6 +1252,9 @@ This GDB was configured as follows:\n\
> --without-babeltrace\n\
> "));
> #endif
> + fprintf_filtered (stream, _("\n\
> + (\"Relocatable\" means directory can be moved with the GDB installation tree.)\n\
> +"));
> }
If you want to print something here, then I think you need to take
into account whether "relocatable" is printed at all.
There are lots of places where it may be printed, and each is
conditioned by a macro like FOO_RELOCATABLE.
Taking into account all those macros (and having to maintain the
result over time) seems problematic.
How about just a sentence or two in the manual near the description of
--configuration (or some such).