This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix CTRL-C for remote.c (PR remote/15297)
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Sergio Durigan Junior <sergiodj at redhat dot com>
- Date: Fri, 21 Jun 2013 14:56:31 +0200
- Subject: Re: [patch] Fix CTRL-C for remote.c (PR remote/15297)
- References: <20130617062652 dot GA26382 at host2 dot jankratochvil dot net> <51C1E35B dot 2000602 at redhat dot com>
On Wed, 19 Jun 2013 18:59:07 +0200, Pedro Alves wrote:
> How does this compare to:
>
> http://sourceware.org/ml/gdb-patches/2013-05/msg00933.html
* The patch solves better sending CTRL-C gdb->gdbserver. My patch would in
some cases stop only on the next "stepi" (when SIGINT gets fully
propagated), your patch prevents sending CTRL-C to gdbserver if GDB already
got stop status in the meantime.
* Your patch handles better/correctly sending CTRL-C to gdbserver in non-stop
mode, I just sent CTRL-C while one should send vCont;t instead.
* Your patch does not handle the (in fact unrelated) safety of the signal
handler so it is automatically testable by the testcase of mine as GDB locks
up in malloc crash due to it.
I will merge it somehow next week as I guess you would not be happy without
the CTRL-C-when-stopped optimization from your patch.
Thanks,
Jan