This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] don't keep a gdb-specific date
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 20 Jun 2013 14:07:03 -0600
- Subject: Re: [PATCH v3] don't keep a gdb-specific date
- References: <1371747149-9423-1-git-send-email-tromey at redhat dot com> <51C34296 dot 6080806 at redhat dot com>
>> echo '#include "server.h"' >> version.c-tmp
Pedro> Can this be just version.h, like GDB's ?
Yes. I fixed it.
>> - echo 'const char version[] = "'"`sed q ${srcdir}/../version.in`"'";' >> version.c-tmp
>> + echo 'const char version[] = "'"`sed q version.tmp`"'";' >> version.c-tmp
>> echo 'const char host_name[] = "$(host_alias)";' >> version.c-tmp
>> mv version.c-tmp version.c
>> + rm -f version.tmp
>> version.o: version.c $(server_h)
Pedro> Then we could move all this shell code to a script under
Pedro> common/ that would be called by both gdb and gdbserver. Or
Pedro> a Makefile fragment that's sourced by both Makefiles with
Pedro> the version.c rule (is the version.o rule in gdbserver still
Pedro> necessary?). Anyway, please don't feel compelled to do that.
Pedro> It can always be done afterwards. This version is already
Pedro> super fine with me.
I made a shell script and removed the version.o target.
I also noticed that I'd neglected to update doc/Makefile.in. The new
patch does that. I'll send it momentarily.
Tom