This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch v9 1/5] New remove-symbol-file command.
- From: Luis Machado <lgustavo at codesourcery dot com>
- To: "Blanc, Nicolas" <nicolas dot blanc at intel dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "Hafiz_Abid at mentor dot com" <Hafiz_Abid at mentor dot com>, "palves at redhat dot com" <palves at redhat dot com>, "tromey at redhat dot com" <tromey at redhat dot com>, "eliz at gnu dot org" <eliz at gnu dot org>, "yao at codesourcery dot com" <yao at codesourcery dot com>, "dje at google dot com" <dje at google dot com>
- Date: Wed, 19 Jun 2013 09:23:23 -0300
- Subject: Re: [patch v9 1/5] New remove-symbol-file command.
- References: <1371566833-4713-1-git-send-email-nicolas dot blanc at intel dot com> <1371566833-4713-2-git-send-email-nicolas dot blanc at intel dot com> <51C0982C dot 7080203 at codesourcery dot com> <388084C8C1E6A64FA36AD1D656E485661A7A5125 at IRSMSX106 dot ger dot corp dot intel dot com>
- Reply-to: lgustavo at codesourcery dot com
On 06/19/2013 09:18 AM, Blanc, Nicolas wrote:
Hi Luis,
A colleague of mine pointed out the gdb_indent.sh script for fixing indentation issues.
So I run the script over my code and fixed the issues that it reported, but the tool did not complain about
the indentation of "macro" loops, such as below. In addition, the indentation these of loops is inconsistent in
GDB, which is really confusing.
So are you sure that the indentation below is incorrect?
Their use is indeed inconsistent throughout GDB. I always go with
further identation. But i don't have a strong opinion here.
Not a blocker from a patch reviewing perspective on my part.
Thanks,
Luis