This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] ChangeLog width 74 -> 80
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 18 Jun 2013 19:53:22 +0200
- Subject: Re: [patch] ChangeLog width 74 -> 80
- References: <20130618150401 dot GA24795 at host2 dot jankratochvil dot net> <51C07B94 dot 3080606 at redhat dot com> <20130618153005 dot GA26742 at host2 dot jankratochvil dot net> <51C07FCC dot 6090706 at redhat dot com> <20130618154752 dot GA27499 at host2 dot jankratochvil dot net> <51C08639 dot 4080506 at redhat dot com>
On Tue, 18 Jun 2013 18:09:29 +0200, Pedro Alves wrote:
> The patch does:
>
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -7060,7 +7060,7 @@ For older changes see ChangeLog-2012.
> Local Variables:
> mode: change-log
> left-margin: 8
> -fill-column: 74
> +fill-column: 80
>
> You surely know that's an emacs setting.
The patch was there to update the Emacs setting as it would no longer match
the coding standard (if the 80 columns get approved).
I could also post an equivalent patch removing the Emacs setting instead.
But such patch would be more difficult to get through and it would be also
rather off-topic to what the mail was trying to do.
> >> As I said, I really don't care that much about the precise width.
> >> It'd be nice to have it changed consistently across the tree
> >> though.
> >
> > One should define first what is "the tree", currently it contains many
> > directions which seems irrelevant for GDB decisions to me (tcl, texinfo,
> > newlib, rda, ...).
>
> Sure, the things outside src/gdb/ that are part of gdb as well:
>
> src/, src/bfd/, src/include/, src/include/gdb/, etc.
OK, the tree from default CVS checkout of virtual directory "gdb".
> I'm all for consistency, so on my part, if this results in
> better consistency, go for it.
Great.
> Please update gdb/testsuite/ChangeLog gdb/doc/ChangeLog too though.
True. I will post a new patch.
Thanks,
Jan