This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] PR 15075 dprintf interferes with "next"
- From: Hui Zhu <teawater at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches at sourceware dot org, Keith Seitz <keiths at redhat dot com>, Yao Qi <yao at codesourcery dot com>
- Date: Mon, 17 Jun 2013 15:32:02 +0800
- Subject: Re: [RFC] PR 15075 dprintf interferes with "next"
- References: <1361192891-29341-1-git-send-email-yao at codesourcery dot com> <8738wpd3qe dot fsf at fleche dot redhat dot com> <CANFwon3DymreN3ost7ZSrd0deb_sBC6YTzk1fpv8k+7d0ADnLg at mail dot gmail dot com> <5176C14B dot 6010603 at redhat dot com> <CANFwon1tTZTVcn7ieP5=HnPy+2hCKP1my-UE1-Xosp=Q6WrGug at mail dot gmail dot com> <51774714 dot 9060306 at codesourcery dot com> <CANFwon2Q_=++=WbZD25Ch6qnRtpmuVBOsmkqhevyMAnM3y+ZZA at mail dot gmail dot com> <CANFwon0A4wmgEuREeQHYfRWMfn_cct6dHCZ6_oFH+wVr1Wym4A at mail dot gmail dot com> <51969A92 dot 80003 at redhat dot com> <CANFwon3OaNBrvw4jwv_RJ8ws+SVx9NctfTw2FSDVowaxAmgF9Q at mail dot gmail dot com> <519CBE2B dot 7060007 at redhat dot com> <CANFwon0-r4ozDwZ5Av_3Uv_r=FFG4QFRs79-9+g1s0SxjMbUSg at mail dot gmail dot com> <CANFwon0zctGb3jwbYYnUWuAKOctR+7MvFg66bB=iPCCN50UquQ at mail dot gmail dot com> <51ACD6ED dot 7040604 at redhat dot com> <CANFwon2oFaTc0ey4B7z=OXcne42SRwp_mozfOYKU4nx-K+80nA at mail dot gmail dot com>
Ping http://sourceware.org/ml/gdb-patches/2013-06/msg00139.html
Thanks,
Hui
On Fri, Jun 7, 2013 at 11:15 AM, Hui Zhu <teawater@gmail.com> wrote:
> Hi Pedro,
>
> Thanks for your review.
>
> On Tue, Jun 4, 2013 at 1:48 AM, Pedro Alves <palves@redhat.com> wrote:
>> On 06/03/2013 05:06 AM, Hui Zhu wrote:
>>> Ping http://sourceware.org/ml/gdb-patches/2013-05/msg00958.html
>>>
>>
>> As this exposes the non-stop racy failure, we should fix it that one
>> first. Failing that, we should kfail or skip the test with
>> remote targets. Let's consider the latter option later if we don't
>> manage to address the race timely. As I said on:
>>
>> http://sourceware.org/ml/gdb-patches/2013-05/msg01111.html
>>
>> I'm investigating this. I have a prototype patch, but I need
>> a bit more to handle some details, like what to do with
>> signal catchpoints when we find threads had been stopped with
>> a signal (I'm currently thinking of skipping the catchpoints).
>> I'm composing a test to exercise/expose this kind of stuff,
>> for a better RFC.
>
> I add a check in the begin of dprintf-non-stop.exp. Then if the
> target in remote, this test will not support.
>
> Please help me review it.
>
> Thanks,
> Hui
>
> 2013-06-07 Yao Qi <yao@codesourcery.com>
> Hui Zhu <hui@codesourcery.com>
> Pedro Alves <palves@redhat.com>
>
> PR breakpoints/15075
> PR breakpoints/15434
> * breakpoint.c (bpstat_stop_status): Call
> b->ops->after_condition_true.
> (update_dprintf_command_list): Don't append "continue" command
> to the command list of dprintf breakpoint.
> (base_breakpoint_after_condition_true): New function.
> (base_breakpoint_ops): Add base_breakpoint_after_condition_true.
> (dprintf_create_breakpoints_sal,
> dprintf_after_condition_true): New functions.
> (initialize_breakpoint_ops): Set dprintf_create_breakpoints_sal
> and dprintf_after_condition_true.
> * breakpoint.h (breakpoint_ops): Add after_condition_true.
>
> 2013-06-07 Yao Qi <yao@codesourcery.com>
> Hui Zhu <hui@codesourcery.com>
>
> PR breakpoints/15075
> PR breakpoints/15434
> * gdb.base/dprintf-next.c: New file.
> * gdb.base/dprintf-next.exp: New file.
> * gdb.base/dprintf-non-stop.c: New file.
> * gdb.base/dprintf-non-stop.exp: New file.
> * gdb.base/dprintf.exp: Don't check "continue" in the output
> of "info breakpoints".
> * gdb.mi/mi-breakpoint-changed.exp (test_insert_delete_modify):
> Don't check "continue" in script field.