This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb/testsuite/gdb.threads: Make sure TLS tests link against pthreads.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Will Newton <will dot newton at linaro dot org>
- Cc: Andrew Pinski <pinskia at gmail dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Patch Tracking <patches at linaro dot org>
- Date: Wed, 12 Jun 2013 12:26:42 +0200
- Subject: Re: [PATCH] gdb/testsuite/gdb.threads: Make sure TLS tests link against pthreads.
- References: <51B22910 dot 7010208 at linaro dot org> <CA+=Sn1=K2QkVFW0J7=_dimQ57GgeP44AmrNYqakNDDybL83-Sg at mail dot gmail dot com> <CANu=DmhfirgXvZC9txdj+=uSV3mpbOY2j7EQQzE7BxisGoZp8Q at mail dot gmail dot com>
> > I think this should be an debian/Ubuntu local only patch as the
> > default for FSF GCC/binutils is not to pass --as-needed.
>
> I admit the change is a little, erm, weird, but my hope was to avoid
> causing pain to people who build gdb on Ubuntu. This isn't just Ubunto
> or Debian developers but Ubuntu or Debian users that happen to have
> downloaded a gdb tarball from gnu.org. Similar test failures in
> binutils have been worked around by adding -Wl,--no-as-needed which we
> could also do here, but I was concerned that this may break non-gcc
> compilers.
I tend to agree that it can be potentially useful, and since it does
not appear to be very disruptive, I find it acceptable in principle.
I just haven't had time to look into it in more details...
--
Joel