This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit/windows] Add thread ID in SuspendThread error warning message.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 11 Jun 2013 12:21:46 +0200
- Subject: [commit/windows] Add thread ID in SuspendThread error warning message.
From: brobecke <brobecke@metz.(none)>
Hello,
This patch adds the thread ID to a warning printed when a call to
SuspendThread fails. It will help investigate issues, particularly
when correlated with the various debug traces provided by the
windows-nat module.
For the record, the output has been changed from...
warning: SuspendThread failed. (winerr 6)
... to ...
warning: SuspendThread (tid=0x720) failed. (winerr 6)
gdb/ChangeLog:
* window-nat.c (thread_rec): Add thread ID in SuspendThread
warning message.
Tested on x86-windows, and checked in.
---
gdb/ChangeLog | 5 +++++
gdb/windows-nat.c | 5 +++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 493da1d..2fb7ac8 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2013-06-11 Joel Brobecker <brobecker@adacore.com>
+
+ * window-nat.c (thread_rec): Add thread ID in SuspendThread
+ warning message.
+
2013-06-08 Pedro Alves <pedro@codesourcery.com>
Yao Qi <yao@codesourcery.com>
diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index 8320d27..66c44eb 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -311,8 +311,9 @@ thread_rec (DWORD id, int get_context)
if (SuspendThread (th->h) == (DWORD) -1)
{
DWORD err = GetLastError ();
- warning (_("SuspendThread failed. (winerr %u)"),
- (unsigned) err);
+ warning (_("SuspendThread (tid=0x%x) failed."
+ " (winerr %d)"),
+ (unsigned) id, (unsigned) err);
return NULL;
}
th->suspended = 1;
--
1.7.10.4