This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/5] Add id of TSV into traceframe_info.
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 07 Jun 2013 17:39:01 +0300
- Subject: Re: [PATCH 3/5] Add id of TSV into traceframe_info.
- References: <1370610493-26468-1-git-send-email-yao at codesourcery dot com> <1370610493-26468-4-git-send-email-yao at codesourcery dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Yao Qi <yao@codesourcery.com>
> Date: Fri, 7 Jun 2013 21:08:11 +0800
>
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -91,6 +91,8 @@ show range-stepping
> the number of control packets from/to GDB. See "New remote packets"
> below.
>
> +* GDB now understands the element 'tvar' in the XML traceframe info.
> +
Shouldn't we tell what that element means or does?
> + ** GDBserver now adds element 'tvar' in the XML in the reply to
> + 'qXfer:traceframe-info:read'.
And here.
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -41790,17 +41790,27 @@ A region of collected memory starting at @var{addr} and extending for
> <memory start="@var{addr}" length="@var{length}"/>
> @end smallexample
>
> +@item
> +A block indicating trace state variable numbered @var{number} has been
> +collected:
> +
> +@smallexample
> +<tvar id="@var{number}"/>
> +@end smallexample
> +
> @end itemize
>
> The formal DTD for the traceframe info format is given below:
>
> @smallexample
> -<!ELEMENT traceframe-info (memory)* >
> +<!ELEMENT traceframe-info (memory | tvar)* >
> <!ATTLIST traceframe-info version CDATA #FIXED "1.0">
>
> <!ELEMENT memory EMPTY>
> <!ATTLIST memory start CDATA #REQUIRED
> length CDATA #REQUIRED>
> +<!ELEMENT tvar>
> +<!ATTLIST tvar id CDATA #REQUIRED>
> @end smallexample
This part is OK.
Thanks.