This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Teach -data-list-register-values to not include unavailable registers


> From: Yao Qi <yao@codesourcery.com>
> Date: Fri, 7 Jun 2013 20:54:10 +0800
> 
> This patch adds an option --skip-unavailable to MI command
> -data-list-register-values, so that unavailable registers are not
> displayed (on the context of traceframes).

"Skip unavailable" is double negation.  How about -show-available
instead?

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -76,6 +76,10 @@ show range-stepping
>  
>    ** The new command -dprintf-insert sets a dynamic printf breakpoint.
>  
> +  ** The command -data-list-register-values now accepts an optional
> +     "--skip-unavailable" option.  When used, only available registers
> +     are displayed.                           ^^^^^^^^^^^^^^

"only the available"

>  Display the registers' contents.  @var{fmt} is the format according to
>  which the registers' contents are to be returned, followed by an optional
>  list of numbers specifying the registers to display.  A missing list of
> -numbers indicates that the contents of all the registers must be returned.
> +numbers indicates that the contents of all the registers must be
> +returned.  In the context of trace frames, the
> +@code{--skip-unavailable} option indicates that only available
> +(collected) registers are returned.
                         ^^^^^^^^^^^^
"are to be returned".  And why do you need the first part of that
sentence, about the "context of trace frames"?  Does it add anything
to the description?

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]