Re: [patch] Improve symbol lookup performance noted in PR 15519

[Doug Evans <dje at google dot com>]

On Thu, Jun 6, 2013 at 3:18 AM, Pedro Alves <palves@redhat.com> wrote:
>>  # Check inheritance of typedefs.
>> -foreach klass {"A" "D" "E" "F"} {
>> +foreach klass {"A" "D" "E" "F" "A2" "D2"} {
>>      gdb_test "ptype ${klass}::value_type" "type = int"
>>      gdb_test "whatis ${klass}::value_type" "type = int"
>>      gdb_test "p (${klass}::value_type) 0" " = 0"
>> @@ -57,6 +58,13 @@ if ![runto 'marker1'] then {
>>      continue
>>  }
>>
>> +# Check inheritance of typedefs again, but this time with an active block.
>> +foreach klass {"A" "D" "A2" "D2"} {
>> +    gdb_test "ptype ${klass}::value_type" "type = int"
>> +    gdb_test "whatis ${klass}::value_type" "type = int"
>> +    gdb_test "p (${klass}::value_type) 0" " = 0"
>> +}
>> +
>
> Looks like this will create duplicate messages in gdb.sum.
> Could you use with_test_prefix to make them unique please?

Fixed.

>>  # Print class types and values.
>> Index: testsuite/gdb.cp/derivation2.cc
>> ===================================================================
>> RCS file: testsuite/gdb.cp/derivation2.cc
>> diff -N testsuite/gdb.cp/derivation2.cc
>> --- /dev/null 1 Jan 1970 00:00:00 -0000
>> +++ testsuite/gdb.cp/derivation2.cc   5 Jun 2013 22:21:18 -0000
>> @@ -0,0 +1,49 @@
> ...
>> +   You should have received a copy of the GNU General Public License
>> +   along with this program.  If not, see <http://www.gnu.org/licenses/>.
>> +   */
>
> (this placement for */ looks a little odd.)

Cut-n-paste from derivation.cc.

bash$ grep "^ *[*]/$" testsuite/*/*.* | wc
    277     482    7364

I'm not going to worry about it.

Attachment: gdb-130606-derivation-test-names-1.patch.txt
Description: Text document