This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Don't set dir separator if path has drive spec

From: Yao Qi <yao at codesourcery dot com>
To: Doug Evans <dje at google dot com>
Cc: gdb-patches <gdb-patches at sourceware dot org>
Date: Tue, 4 Jun 2013 09:34:17 +0800
Subject: Re: [PATCH] Don't set dir separator if path has drive spec
References: <1370306007-877-1-git-send-email-yao at codesourcery dot com> <CADPb22Q+fBof0Rf7ZNng26TxBUe51sQgBohGDNDrcoz+kU4KHA at mail dot gmail dot com>

On 06/04/2013 08:48 AM, Doug Evans wrote:

-      need_dir_separator = !IS_DIR_SEPARATOR (in_pathname[0]);
>+      need_dir_separator = (!IS_DIR_SEPARATOR (in_pathname[0])
>+                           && !HAS_TARGET_DRIVE_SPEC (fskind, in_pathname));
>
>        /* Cat the prefixed pathname together.  */
>        temp_pathname = concat (sysroot,


Hi.  Looks right to me.

Doug, thanks for the review. I check the indentation in Emacs and theformatting looks right. Patch is committed.


--
Yao (éå)

References:
- [PATCH] Don't set dir separator if path has drive spec
  - From: Yao Qi
- Re: [PATCH] Don't set dir separator if path has drive spec
  - From: Doug Evans

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]