This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Small patch to enable build of gdb-7.6 for GNU/Hurd
- From: Svante Signell <svante dot signell at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Sergio Durigan Junior <sergiodj at redhat dot com>, Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Mon, 27 May 2013 15:57:07 +0200
- Subject: Re: Small patch to enable build of gdb-7.6 for GNU/Hurd
- References: <1369326967 dot 8127 dot 33 dot camel at s1499 dot it dot kth dot se> <m3mwrlm6al dot fsf at redhat dot com> <20130524042734 dot GG4017 at adacore dot com> <519F2A7A dot 4050002 at redhat dot com> <1369386446 dot 8127 dot 51 dot camel at s1499 dot it dot kth dot se> <m3hahslp0a dot fsf at redhat dot com> <1369654913 dot 8127 dot 84 dot camel at s1499 dot it dot kth dot se> <20130527121028 dot GB5751 at adacore dot com> <1369657278 dot 8127 dot 90 dot camel at s1499 dot it dot kth dot se> <1369662500 dot 8127 dot 97 dot camel at s1499 dot it dot kth dot se>
On Mon, 2013-05-27 at 15:48 +0200, Svante Signell wrote:
> On Mon, 2013-05-27 at 14:21 +0200, Svante Signell wrote:
> > On Mon, 2013-05-27 at 16:10 +0400, Joel Brobecker wrote:
> > > > 2013-05-27 Svante Signell <srs@hurd-2013.my.own.domain>
> > > >
> > > > * nto-tdep.c (nto_init_solib_absolute_prefix): Solve build
> > > > problems for systems not defining PATH_MAX by using xstrprintf and
> > > > a cleanup.
> > >
> > > Is the domain name above really valid?
> >
> > No, it's a local one. I forgot to change that one.
>
> Attaching an ChangeLog entry with a correct domain
>
> > > While looking at this code, I don't think you'll need 2 xstrprintf
> > > either. Can you try the attached patch?
> >
> > Yes, of course this code is much neater. I will report build status
> > soon.
>
> I had to change the second make_cleanup call to do_cleanups instead, see
> the updated patch. OK now?
Additionally, I think the char buf; statement should read char *buf; in
the patch.