This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/5] range stepping: gdbserver (x86 GNU/Linux)
- From: Yao Qi <yao at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 23 May 2013 08:56:52 +0800
- Subject: Re: [PATCH 4/5] range stepping: gdbserver (x86 GNU/Linux)
- References: <20130514191026 dot 13213 dot 39574 dot stgit at brno dot lan> <20130514191054 dot 13213 dot 58686 dot stgit at brno dot lan>
On 05/15/2013 03:10 AM, Pedro Alves wrote:
@@ -2063,9 +2067,22 @@ handle_v_cont (char *own_buf)
goto err;
resume_info[i].sig = gdb_signal_to_host (sig);
}
+ else if (p[0] == 'r')
+ {
+ char *p1;
+
+ p = p + 1;
+ p1 = strchr (p, ',');
+ decode_address (&resume_info[i].step_range_start, p, p1 - p);
+
+ p = p1 + 1;
+ p1 = strchr (p, ':');
+ decode_address (&resume_info[i].step_range_end, p, p1 - p);
+
+ p = p1;
+ }
else
{
- resume_info[i].sig = 0;
What is the purpose to remove this line?
p = p + 1;
}
The patch looks good to me.
So in the end, seeing how all was always in the target, I just went with
leaving the fields Linux specific, rather than leave the fields dangling on
other targets, thinking it'd be easy enough to reconsider once other
targets implement range stepping. Meanwhile, other targets wouldn't
pay for extra fields they don't use.
OK, that is fine to me.
--
Yao (éå)