This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: fix gdb_assert caused by 'catch signal ...' and fork
- From: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 21 May 2013 20:49:15 +0200
- Subject: Re: RFA: fix gdb_assert caused by 'catch signal ...' and fork
- References: <1368136582 dot 30058 dot 7 dot camel at soleil> <518D2C4F dot 8070102 at redhat dot com> <1368736234 dot 2225 dot 30 dot camel at soleil> <51967454 dot 7000306 at redhat dot com>
On Fri, 2013-05-17 at 19:17 +0100, Pedro Alves wrote:
> >>> + (void) wait(NULL);
> IMO, that's more noise than signal. We ignore return values in
> many many cases, and don't do that (including other wait calls in
> the testsuite).
Removed the '(void)'
>
> > I also added a comment in breakpoint.c, to explain why
> > the bp_loc_other locations are not removed.
> >
> > Ok to apply ?
>
> Looks good to me. Give it a couple days more, in case Doug or
> others wants to comment, and check it in then.
and committed.
Thanks
Philippe