This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]
- From: Pedro Alves <palves at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Keith Seitz <keiths at redhat dot com>, Sergio Durigan Junior <sergiodj at redhat dot com>, "gdb-patches at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Thu, 16 May 2013 11:18:49 +0100
- Subject: Re: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]
- References: <51895A2F dot 8000504 at redhat dot com> <CADPb22Sj_5Bp+FhoQYk_9vR5c1D3fXsw4gLFu7v+jmDNSaOPFg at mail dot gmail dot com> <5191340B dot 60100 at redhat dot com> <519156F5 dot 5090000 at redhat dot com> <5193C786 dot 4000207 at redhat dot com> <5193E2DC dot 5000200 at redhat dot com> <m3r4h7kh4p dot fsf at redhat dot com> <51941E85 dot 8010104 at redhat dot com> <5194A48D dot 4060806 at redhat dot com> <20130516092601 dot GI5555 at adacore dot com>
On 05/16/2013 10:26 AM, Joel Brobecker wrote:
>> Please use gdb_test_multiple. See e.g., how completion.exp itself
>> simplified much when converted to it:
>>
>> http://sourceware.org/ml/gdb-patches/2011-05/msg00063.html
>
> I also just checked in a test that performs a completion test
> using send_gdb + gdb_test_multiple...
>
> http://www.sourceware.org/ml/gdb-patches/2013-05/msg00573.html
Ah,
> --- a/gdb/testsuite/gdb.ada/complete.exp
> +++ b/gdb/testsuite/gdb.ada/complete.exp
> @@ -175,4 +175,19 @@ test_gdb_complete "pck." \
> test_gdb_complete "<pck__my" \
> "p <pck__my_global_variable>"
...
That made me look at what test_gdb_complete is, and then I
noticed a FIXME that's super easily fixed nowadays. :-)
http://sourceware.org/ml/gdb-patches/2013-05/msg00584.html
I went ahead and checked in the fix as obvious.
--
Pedro Alves