This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix bug 15433 - GDB crashes when using agent dprintf, %s format, and an in-line string
- From: Tom Tromey <tromey at redhat dot com>
- To: Hui Zhu <teawater at gmail dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Mon, 13 May 2013 10:35:58 -0600
- Subject: Re: [PATCH] Fix bug 15433 - GDB crashes when using agent dprintf, %s format, and an in-line string
- References: <CANFwon1MsCu4Abzdh75jB5i-+rXZizYb_Rwx++cnBxzJhV5_Cw at mail dot gmail dot com>
>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
Hui> + if (aexpr == NULL)
Hui> + error (_("Agent is not support commands of breakpoint %d."),
Hui> + bl->owner->number);
In addition to what Yao said, this change seems roughly equivalent to
simply removing the TRY_CATCH from parse_cmd_to_aexpr. (You'd have to
clear loc->cmd_bytecode first, but it seems to me that this has to be
done anyway, because parse_cmd_to_aexpr can already call error...)
I also still don't understand the code to set null_command_or_parse_error.
Maybe you explained it to me last time, but I forget. If it is actually
correct as-is, I would appreciate a comment explaining it.
Tom