This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] add -s option to make -break-insert support dprintf
- From: Tom Tromey <tromey at redhat dot com>
- To: Hui Zhu <teawater at gmail dot com>
- Cc: Pedro Alves <palves at redhat dot com>, Eli Zaretskii <eliz at gnu dot org>, Hui Zhu <hui_zhu at mentor dot com>, gdb-patches ml <gdb-patches at sourceware dot org>, Marc Khouzam <marc dot khouzam at ericsson dot com>
- Date: Fri, 10 May 2013 09:21:58 -0600
- Subject: Re: [PATCH] add -s option to make -break-insert support dprintf
- References: <515451EA dot 1000200 at mentor dot com> <83y5d7wpvq dot fsf at gnu dot org> <CANFwon23qn_SVjcUWUZ2Z2Y5Euqg8efiwMvXkxTRtA9-2Ttk3Q at mail dot gmail dot com> <516454DA dot 9040109 at redhat dot com> <CANFwon1aDoyCYrsNeUpkmh6ARFJmT8B4JdFqYcc6GLdo=cgqig at mail dot gmail dot com> <87ppxzhfqy dot fsf at fleche dot redhat dot com> <CANFwon2_yT4SOpK7=Rq=91nFcvk2Rn3_wAkCMmsfgP-6iynGig at mail dot gmail dot com> <516C2549 dot 3060808 at redhat dot com> <CANFwon0WYLZEKWkfHzRgCB8MOPPoCsDvSaCk0SSYXPgonuE5zw at mail dot gmail dot com> <87vc7ithtj dot fsf at fleche dot redhat dot com> <CANFwon0jwdrDULV+bPRX_5AWE2tgq=rSrA6eyZEujZqPfN+Huw at mail dot gmail dot com> <87wqrrll9m dot fsf at fleche dot redhat dot com> <CANFwon3yyKxMVRO3wJ3=VTDLpege_NWByMA9-jk_g9_a5mXaoQ at mail dot gmail dot com> <87d2t2tt02 dot fsf at fleche dot redhat dot com> <CANFwon3meTbHqy-kfibR6XiJpkZdS3348am2wP6i9Dbz_sowLg at mail dot gmail dot com>
Hui> + if (isprint(argv[0][i]))
Missing space before "(".
Hui> + char tmp[5];
Hui> + sprintf (tmp, "\\%o", (unsigned char)argv[0][i]);
Missing newline between these lines.
Missing space after ")".
Hui> + if (dprintf)
Hui> + {
Hui> + int format_num = oind + 1;
Hui> +
Hui> + if (hardware || tracepoint)
Hui> + error (_("-dprintf-insert: does not support -h or -a"));
Hui> + if (format_num >= argc)
Hui> + error (_("-dprintf-insert: Missing <format>"));
Hui> +
Hui> + extra_string = mi_argv_to_format (argv + format_num, argc - format_num);
Hui> + extra_string_cleanup = make_cleanup (xfree, extra_string);
It is better to just install an outer null cleanup and invoke that at
the end.
Tom