This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] Remove FIXME in solib-aix.c:solib_aix_relocate_section_addresses
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Date: Fri, 10 May 2013 17:26:37 +0400
- Subject: [commit] Remove FIXME in solib-aix.c:solib_aix_relocate_section_addresses
Hello,
This issue should now be fixed thanks to a change in bfd removing
the SEC_ALLOC flag from all sections that do not get mapped to
memory:
http://sourceware.org/ml/binutils/2013-05/msg00122.html
gdb/ChangeLog:
* solib-aix.c (solib_aix_relocate_section_addresses):
Remove FIXME comment.
Checked in.
---
gdb/ChangeLog | 5 +++++
gdb/solib-aix.c | 10 ----------
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7ee965a..7de7db7 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2013-05-10 Joel Brobecker <brobecker@adacore.com>
+ * solib-aix.c (solib_aix_relocate_section_addresses):
+ Remove FIXME comment.
+
+2013-05-10 Joel Brobecker <brobecker@adacore.com>
+
PR tdep/15420:
* sol-thread.c (ps_lgetxregsize, ps_lgetxregs, ps_lsetxregs):
New functions, directly copied from sparc-sol-thread.c.
diff --git a/gdb/solib-aix.c b/gdb/solib-aix.c
index 9fa5de9..5af2445 100644
--- a/gdb/solib-aix.c
+++ b/gdb/solib-aix.c
@@ -418,16 +418,6 @@ solib_aix_relocate_section_addresses (struct so_list *so,
else
{
/* All other sections should not be relocated. */
- /* FIXME: GDB complains that the .loader section sometimes
- overlaps with other sections (Eg: the .data section).
- As far as I can tell, the loader section had the LOAD flag
- set, but not the RELOC. So it should not be relocated.
- There seems to be a problem there, and maybe it has to do
- with setting sec->addr to 0 (when the vma is indeed 0).
- But even if there wasn't, the problem then becomes the fact
- that many shared objects inside shared libraries have
- a .loader section whose vma is 0, thus also triggering
- an overlap warning. */
sec->addr = bfd_section_vma (abfd, bfd_sect);
sec->endaddr = sec->addr + bfd_section_size (abfd, bfd_sect);
}
--
1.7.10.4