This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/7] PR gdb/15224 fix for Unify interactivity tests to use input_from_terminal_p
- From: Pedro Alves <palves at redhat dot com>
- To: mbilal <mbilal at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org, jan dot kratochvil at redhat dot com
- Date: Wed, 08 May 2013 17:21:40 +0100
- Subject: Re: [PATCH 2/7] PR gdb/15224 fix for Unify interactivity tests to use input_from_terminal_p
- References: <51877A32 dot 1030503 at codesourcery dot com> <51877A99 dot 4060503 at codesourcery dot com> <5188AA15 dot 5010904 at codesourcery dot com> <5188AC27 dot 1050407 at codesourcery dot com> <5188AC99 dot 6060504 at codesourcery dot com> <518A0B4E dot 50808 at codesourcery dot com>
Hi,
Thanks for the patch.
> ping?
Please give it at least a week before pinging.
On 05/08/2013 09:22 AM, mbilal wrote:
> On 05/07/2013 12:26 PM, mbilal wrote:
>> Here is a updated patch for fix for Unify interactivity tests to use input_from_terminal_p:
>> Index: event-top.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/event-top.c,v
>> retrieving revision 1.94
>> diff -u -p -r1.94 event-top.c
>> --- event-top.c 21 Mar 2013 17:37:29 -0000 1.94
>> +++ event-top.c 7 May 2013 07:03:33 -0000
>> @@ -604,7 +604,8 @@ command_line_handler (char *rl)
>>
>> /* Add line to history if appropriate. */
>> if (instream == stdin
>> - && ISATTY (stdin) && *linebuffer)
>> + && ISATTY (stdin) && *linebuffer
>> + && input_from_terminal_p())
>> add_history (linebuffer);
I'd guess that input_from_terminal_p already does some of the
checks this is also making, so that this could be simplified.
Missing space before parens.
A ChangeLog entry is missing.
--
Pedro Alves