This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 2/2] Assert leftover cleanups in TRY_CATCH
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 07 May 2013 09:26:29 -0600
- Subject: Re: [patch 2/2] Assert leftover cleanups in TRY_CATCH
- References: <20130501165750 dot GA453 at host2 dot jankratochvil dot net> <87obcoyot3 dot fsf at fleche dot redhat dot com> <20130507062305 dot GH5278 at adacore dot com> <87ip2uvonz dot fsf at fleche dot redhat dot com>
Tom> Alternatively I think we could probably change all the code to be
Tom> cleanup-checker-clean. I'll try to prep that series soon to see what
Tom> people think. I think it actually less work.
Actually, I forgot how hard this is.
There are some tricky cases -- e.g., try to remove the dangling cleanup
from c-exp.y:operator_stoken, or from
ada-lang.c:old_renaming_is_invisible.
Or, there is some spaghetti code, like
disasm.c:do_mixed_source_and_assembly.
And, there is some code where I don't know what is intended, like
record-full.c:record_full_wait_1 (multiple returns without cleaning up),
or record-btrace.c:record_btrace_insn_history.
So, getting to zero complaints from the checker is not easy.
Maybe I will hack the checker to ignore some issues.
Tom