This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/5] constify to_terminal_info
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 26 Apr 2013 20:12:58 +0100
- Subject: Re: [PATCH 2/5] constify to_terminal_info
- References: <871u9yiku2 dot fsf at fleche dot redhat dot com>
On 04/25/2013 06:25 PM, Tom Tromey wrote:
> This constifies the to_terminal_info method.
>
> I could not test all of it (e.g., go32-nat.c) but I did look by hand
> and it all seems fine. I'd appreciate it if someone with access to
> the proper machines either built this or looked at it.
>
> * go32-nat.c (go32_terminal_info): Make 'args' const.
> * inferior.h (child_terminal_info): Update.
> * inflow.c (child_terminal_info): Make 'args' const.
> * target.c (default_terminal_info): Make 'args' const.
> (debug_to_terminal_save_ours): Likewise.
> * target.h (struct target_ops) <to_terminal_info>: Make argument
> const.
I've built this with the djgpp f17 cross toolchain found at
<ftp://ftp.delorie.com/pub/djgpp/rpms/>.
No build regressions.
(though there are other unrelated build issues).
--
Pedro Alves