This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix create pending breakpoint handle extra_string issue if not parse_condition_and_thread

From: Keith Seitz <keiths at redhat dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Hui Zhu <hui_zhu at mentor dot com>, Tom Tromey <tromey at redhat dot com>, Hui Zhu <teawater at gmail dot com>, gdb-patches ml <gdb-patches at sourceware dot org>
Date: Sat, 06 Apr 2013 14:49:46 -0700
Subject: Re: [PATCH] Fix create pending breakpoint handle extra_string issue if not parse_condition_and_thread
References: <514E8D6C dot 2010606 at mentor dot com> <514EEB43 dot 6040101 at redhat dot com> <CANFwon3rNhdJaaYr1UDy3XJTY2-s5N74QB_LmgVi2d-Qcp4FWQ at mail dot gmail dot com> <87620ftn9f dot fsf at fleche dot redhat dot com> <515092F2 dot 2000307 at redhat dot com> <515F0EED dot 4040105 at redhat dot com>

On 04/05/2013 10:50 AM, Pedro Alves wrote:

I think you're on the right track here.

That's good to know. :-) Honestly, though, that was just meant as anexample -- not a definitive solution to the problem.

That'd mean that e.g., for a future MI dprintf command, we'd accept
the remainder of ARG as extra string.


Gah. I totally spaced on MI.

I made it "parse_arg", as that'll remain stable even
when more explicit parameters are added, and,

break_command_1:

   create_breakpoint (get_current_arch (),
		     arg,
		     NULL, 0, NULL, 1 /* parse arg */,

we even have comments calling it that already too.


A very welcome change.

WDYT?


It looks good to me.

Thank you again for your review of my review. Hopefully next time I'llbe a bit better at it!


Keith

Follow-Ups:
- Re: [PATCH] Fix create pending breakpoint handle extra_string issue if not parse_condition_and_thread
  - From: Pedro Alves

References:
- Re: [PATCH] Fix create pending breakpoint handle extra_string issue if not parse_condition_and_thread
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]