This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: make TAGS "skipping ./: it is not a regular file"
- From: Eli Zaretskii <eliz at gnu dot org>
- To: gdb-patches at sourceware dot org
- Date: Fri, 05 Apr 2013 16:25:31 +0300
- Subject: Re: make TAGS "skipping ./: it is not a regular file"
- References: <83mwtgizuw dot fsf at gnu dot org>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Tue, 02 Apr 2013 20:52:55 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> Remember this:
>
> http://sourceware.org/ml/gdb-patches/2012-08/msg00504.html
>
> ?
>
> Back then I didn't dig deep enough into the second item. Now I did.
> The problem is here:
>
> GDB_NM_FILE = @GDB_NM_FILE@
> TAGS: $(TAGFILES_NO_SRCDIR) $(TAGFILES_WITH_SRCDIR)
> @echo Making TAGS
> @etags $(srcdir)/$(GDB_NM_FILE) \
> `(for i in $(DEPFILES) $(TAGFILES_NO_SRCDIR); do \
> echo $(srcdir)/$$i ; \
> done ; for i in $(TAGFILES_WITH_SRCDIR); do \
> echo $$i ; \
> done) | sed -e 's/\.o$$/\.c/'` \
> `find $(srcdir)/config -name '*.h' -print`
>
> If GDB_NM_FILE is empty, the first argument to etags is just
> $(srcdir)/, which is a directory.
>
> The patch below fixes that. If someone has a better/cleaner/more
> elegant idea, I'm all ears.
>
> OK to commit to the trunk?
No comments, so I went ahead and committed this to the trunk.
> 2013-04-02 Eli Zaretskii <eliz@gnu.org>
>
> * Makefile.in (TAGS): If GDB_NM_FILE is empty, don't pass it
> to etags.
>
> --- gdb/Makefile.in~0 2013-04-02 11:35:49.142382400 +0300
> +++ gdb/Makefile.in 2013-04-02 20:22:23.018050500 +0300
> @@ -1209,7 +1209,7 @@
> GDB_NM_FILE = @GDB_NM_FILE@
> TAGS: $(TAGFILES_NO_SRCDIR) $(TAGFILES_WITH_SRCDIR)
> @echo Making TAGS
> - etags $(srcdir)/$(GDB_NM_FILE) \
> + etags `(test -n "$(GDB_NM_FILE)" && echo "$(srcdir)/$(GDB_NM_FILE)")` \
> `(for i in $(DEPFILES) $(TAGFILES_NO_SRCDIR); do \
> echo $(srcdir)/$$i ; \
> done ; for i in $(TAGFILES_WITH_SRCDIR); do \
>