This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Include putpkt in TRY_CATCH. PR gdb/15275
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Gareth McMullin <gareth at blacksphere dot co dot nz>, gdb-patches at sourceware dot org
- Date: Tue, 2 Apr 2013 16:11:49 +0200
- Subject: Re: Include putpkt in TRY_CATCH. PR gdb/15275
- References: <CAL8qUbrD=fgMP7nE0O8tX=AXifUpQXas25o_4SfK4p79rfoUpw at mail dot gmail dot com> <CAL8qUbqjtBKJFJZ6dPS78Zh8Eb3b33U9JXTmn1pS3Le93xt7Rw at mail dot gmail dot com> <20130325195832 dot GA15218 at host2 dot jankratochvil dot net> <515478BE dot 3030801 at redhat dot com> <20130329140245 dot GA16492 at host2 dot jankratochvil dot net> <515AE52D dot 9020403 at redhat dot com>
On Tue, 02 Apr 2013 16:03:25 +0200, Pedro Alves wrote:
> On 03/29/2013 02:02 PM, Jan Kratochvil wrote:
> > I agree this fix is better. I will revert the previous check-in after this
> > check-in.
>
> Now pushed.
Checked in the revert:
http://sourceware.org/ml/gdb-cvs/2013-04/msg00016.html
and for 7.6:
http://sourceware.org/ml/gdb-cvs/2013-04/msg00017.html
Thanks,
Jan
http://sourceware.org/ml/gdb-cvs/2013-04/msg00016.html
--- src/gdb/ChangeLog 2013/04/02 13:51:06 1.15355
+++ src/gdb/ChangeLog 2013/04/02 14:09:08 1.15356
@@ -1,3 +1,9 @@
+2013-04-02 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ Revert this patch:
+ PR gdb/15275
+ * remote.c (remote_get_trace_status): Include putpkt in TRY_CATCH.
+
2013-04-02 Pedro Alves <palves@redhat.com>
PR gdb/15275
--- src/gdb/remote.c 2013/04/02 13:51:07 1.536
+++ src/gdb/remote.c 2013/04/02 14:09:08 1.537
@@ -10713,9 +10713,10 @@
trace_regblock_size = get_remote_arch_state ()->sizeof_g_packet;
+ putpkt ("qTStatus");
+
TRY_CATCH (ex, RETURN_MASK_ERROR)
{
- putpkt ("qTStatus");
p = remote_get_noisy_reply (&target_buf, &target_buf_size);
}
if (ex.reason < 0)