This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] Don't use unportable macros
- From: Tom Tromey <tromey at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: Yao Qi <yao at codesourcery dot com>, dje at google dot com, gdb-patches at sourceware dot org
- Date: Wed, 20 Mar 2013 11:37:34 -0600
- Subject: Re: [PATCH 3/3] Don't use unportable macros
- References: <83ip4s4ixc dot fsf at gnu dot org> <1363407692-18959-1-git-send-email-yao at codesourcery dot com> <1363407692-18959-4-git-send-email-yao at codesourcery dot com> <CADPb22RwSq0iv_gQu5PSGezQoUy0ve16M2hmL51HvM19v0M5Ow at mail dot gmail dot com> <51492077 dot 30307 at codesourcery dot com> <83sj3qyogk dot fsf at gnu dot org>
>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Wed, 20 Mar 2013 10:35:35 +0800
>> From: Yao Qi <yao@codesourcery.com>
>> CC: gdb-patches <gdb-patches@sourceware.org>, Eli Zaretskii <eliz@gnu.org>
>>
>> Also define a macro 'mkdir' in this patch, as Eli suggested before. Is
>> it OK?
Eli> The macro is OK, but please make sure unistd.h is included by this
Eli> file, because that's where MinGW defines the prototype of _mkdir.
defs.h includes unistd.h.
Tom