This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix agent code generate bug of ref
>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
Hui> On Tue, Mar 12, 2013 at 11:16 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>>> "Hui" == Hui Zhu <hui_zhu@mentor.com> writes:
>>
Hui> According to the discussion with Tom in IRC.
Hui> I add a check before call access_memory.
Hui> + if (size != 1 && size != 2 && size != 4 && size != 8)
Hui> + error (_("Refn doesn't support size %d"),
Hui> + size * TARGET_CHAR_BIT);
>> The old error message mentioned the actual opcode name.
>> I think "Refn" is less clear, since it isn't the name of anything
>> in DWARF.
Hui> What about change it to "DW_OP_deref and DW_OP_deref_size"?
It seems simple to just resurrect the old error message.
Tom