This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] MIPS: Compressed PLT/stubs support
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Alan Modra <amodra at gmail dot com>, <gdb-patches at sourceware dot org>
- Date: Sat, 9 Mar 2013 04:06:36 +0000
- Subject: Re: [PATCH 1/2] MIPS: Compressed PLT/stubs support
- References: <alpine.DEB.1.10.1302072108300.6762@tp.orcam.me.uk> <87wqu19y1x.fsf@fleche.redhat.com> <20130222005833.GJ3080@bubble.grove.modra.org> <20130222060640.GL3080@bubble.grove.modra.org> <87obfc6rga.fsf@fleche.redhat.com>
On Fri, 22 Feb 2013, Tom Tromey wrote:
> Alan> Hmm, perhaps a cleaner change would be implement make_msymbol_special
> Alan> for ppc64 and move the udata.p special case out of elf_symtab_read?
>
> Alan> Like so.
>
> Alan> * elfread.c (elf_symtab_read): Do not use udata.p here to find
> Alan> symbol size.
> Alan> * ppc64-tdep.c (ppc64_elf_make_msymbol_special): New function.
> Alan> * ppc64-tdep.h (ppc64_elf_make_msymbol_special): Declare.
> Alan> * ppc-linux-tdep.c (ppc_linux_init_abi): Set up to use the above.
> Alan> * ppcfbsd-tdep.c (ppcfbsd_init_abi): Likewise.
>
> I like this much better, thanks.
> This is ok.
Thanks for sorting this out -- now the MIPS change does not have to touch
elfread.c anymore.
Maciej