This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[COMMIT PATCH] hex2bin, bin2hex: move declarations to header.
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 07 Mar 2013 17:29:40 +0000
- Subject: [COMMIT PATCH] hex2bin, bin2hex: move declarations to header.
Move the declarations to a header, rather than declaring them in
(multiple) .c files.
gdb/
2013-03-07 Pedro Alves <palves@redhat.com>
* remote.c (hex2bin, bin2hex): Move extern declarations to ...
* remote.h (hex2bin, bin2hex): ... here.
* tracepoint.c (hex2bin, bin2hex): Remove extern declarations.
---
gdb/remote.c | 4 ----
gdb/remote.h | 4 ++++
gdb/tracepoint.c | 3 ---
3 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/gdb/remote.c b/gdb/remote.c
index 88a57c8..b69c8a8 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -183,10 +183,6 @@ static void record_currthread (ptid_t currthread);
static int fromhex (int a);
-extern int hex2bin (const char *hex, gdb_byte *bin, int count);
-
-extern int bin2hex (const gdb_byte *bin, char *hex, int count);
-
static int putpkt_binary (char *buf, int cnt);
static void check_binary_download (CORE_ADDR addr);
diff --git a/gdb/remote.h b/gdb/remote.h
index d49b427..b95370c 100644
--- a/gdb/remote.h
+++ b/gdb/remote.h
@@ -39,6 +39,10 @@ extern void getpkt (char **buf, long *sizeof_buf, int forever);
extern int putpkt (char *buf);
+extern int hex2bin (const char *hex, gdb_byte *bin, int count);
+
+extern int bin2hex (const gdb_byte *bin, char *hex, int count);
+
extern char *unpack_varlen_hex (char *buff, ULONGEST *result);
extern void async_remote_interrupt_twice (void *arg);
diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c
index a212227..c36c1a7 100644
--- a/gdb/tracepoint.c
+++ b/gdb/tracepoint.c
@@ -69,9 +69,6 @@
#define O_LARGEFILE 0
#endif
-extern int hex2bin (const char *hex, gdb_byte *bin, int count);
-extern int bin2hex (const gdb_byte *bin, char *hex, int count);
-
/* Maximum length of an agent aexpression.
This accounts for the fact that packets are limited to 400 bytes
(which includes everything -- including the checksum), and assumes