This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Change trace buffer size
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: "Abid, Hafiz" <hafiz_abid at mentor dot com>, gdb-patches at sourceware dot org, stan at codesourcery dot com
- Date: Wed, 27 Feb 2013 16:54:59 +0000
- Subject: Re: [patch] Change trace buffer size
- References: <1361211216.2217.2@abidh-ubunto1104> <5122E8C9.2070205@codesourcery.com>
On 02/19/2013 02:51 AM, Yao Qi wrote:
>>
>
> We may mention the new remote packet in NEWS.
Indeed. s/may/should/.
>>
>> @@ -912,6 +913,9 @@ update_current_target (void)
>> de_fault (to_set_circular_trace_buffer,
>> (void (*) (int))
>> target_ignore);
>> + de_fault (to_set_trace_buffer_size,
>> + (void (*) (LONGEST))
>> + target_ignore);
>
> I am wondering 'tcomplain' may be better than 'target_ignore'.
I think it's better to have the command behave the
same as the other related "set circular-trace-buffer"
set disconnected-tracing. We've discussed this behavior in
the context of the patch that adds one of these other
commands (or both?).
Do you see a reason this command should behave different?
tcomplain would trigger if you used the "set ..." command
before being connected to any target (or after disconnecting).
--
Pedro Alves