RE: New ARI warning Tue Feb 5 02:01:10 UTC 2013 in -D 2013-02-05-gmt

["Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>]

  Hi all,

As ARI maintainer,
I was wondering if the fact that
  set_gdbarch_write_pc is treated as write_pc
inside the ARI script is really correct:

  I was always considering that gdbarch specific method are
the right way to do things correctly in multi-target GDB.

  Why is then set_gdbarch_write_pc also considered as deprecated?

  If it should not be, the change below would take care of this:

Pierre Muller 
as ARI maintainer.


2013-02-05  Pierre Muller  <muller@sourceware.org>

        * contrib/ari/gdb_ari.sh (write_pc rule): Do not consider
        set_gdbarch_write_pc as deprecated anymore.

Index: gdb_ari.sh
===================================================================
RCS file: /cvs/src/src/gdb/contrib/ari/gdb_ari.sh,v
retrieving revision 1.7
diff -u -p -r1.7 gdb_ari.sh
--- gdb_ari.sh  1 Jan 2013 06:32:56 -0000       1.7
+++ gdb_ari.sh  5 Feb 2013 10:06:14 -0000
@@ -1051,7 +1051,6 @@ a DECR_PC_AFTER_BREAK"
     category["write_pc"] = ari_deprecate
 }
 /(^|[^_[:alnum:]])write_pc[[:space:]]*\(/ || \
-/(^|[^_[:alnum:]])set_gdbarch_write_pc[[:space:]]*\(/ || \
 /(^|[^_[:alnum:]])TARGET_WRITE_PC[[:space:]]*\(/ {
     fail("write_pc")
 }

> > gdb/aarch64-tdep.c:2619: deprecate: write_pc: Replace write_pc() with
> get_frame_base_address or get_frame_id; at present the inferior function
> call code still uses this when doing a DECR_PC_AFTER_BREAK
> gdb/aarch64-tdep.c:2619:  set_gdbarch_write_pc (gdbarch,
aarch64_write_pc);
> gdb/aarch64-tdep.c:2619:  set_gdbarch_write_pc (gdbarch,
aarch64_write_pc);
> 274a277,279
> > gdb/gdbarch.h:740: comment: GNU/Linux: Do not use 'Linux', instead use
> 'Linux kernel' or 'GNU/Linux system'; comments should clearly
differentiate
> between the two (this test assumes that word 'Linux' appears on the same
> line as the word 'GNU' or 'kernel' or a kernel version
> gdb/gdbarch.h:740:/* The elfcore writer hook to use to write Linux
prpsinfo
> notes to core
> > gdb/gdbarch.h:741: comment: GNU/Linux: Do not use 'Linux', instead use
> 'Linux kernel' or 'GNU/Linux system'; comments should clearly
differentiate
> between the two (this test assumes that word 'Linux' appears on the same
> line as the word 'GNU' or 'kernel' or a kernel version
> gdb/gdbarch.h:741:   files.  Most Linux architectures use the same
> prpsinfo32 or
> > gdb/gdbarch.h:743: comment: GNU/Linux: Do not use 'Linux', instead use
> 'Linux kernel' or 'GNU/Linux system'; comments should clearly
differentiate
> between the two (this test assumes that word 'Linux' appears on the same
> line as the word 'GNU' or 'kernel' or a kernel version
> gdb/gdbarch.h:743:   call the Linux generic routines in bfd to write
> prpsinfo notes by
> 556a562
> > gdb/ppc-linux-tdep.c:1451: comment: GNU/Linux: Do not use 'Linux',
instead
> use 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate between the two (this test assumes that word 'Linux' appears
> on the same line as the word 'GNU' or 'kernel' or a kernel version
> gdb/ppc-linux-tdep.c:1451:  /* Initialize the Linux target descriptions.
*/