This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] cleanup: Wunused - amd64

From: Tom Tromey <tromey at redhat dot com>
To: Aleksandar Ristovski <aristovski at qnx dot com>
Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Thu, 31 Jan 2013 11:20:50 -0700
Subject: Re: [patch] cleanup: Wunused - amd64
References: <5109E3D3.90207@qnx.com> <871ud19vvy.fsf@fleche.redhat.com> <510A97F0.5050704@qnx.com>

>>>>> "Aleksandar" == Aleksandar Ristovski <aristovski@qnx.com> writes:

Aleksandar> It is not used. Is it a bug, I don't know, I haven't
Aleksandar> analyzed any deeper (but my patch would not make it any
Aleksandar> worse than what it is now).

I think in this case the patch needs a fuller investigation.  I agree
your patch doesn't change the meaning of the code, but I think that if
there is in fact a bug here, then the patch would obscure that.

Tom

Follow-Ups:
- Re: [patch] cleanup: Wunused - amd64
  - From: Aleksandar Ristovski

References:
- [patch] cleanup: Wunused - amd64
  - From: Aleksandar Ristovski
- Re: [patch] cleanup: Wunused - amd64
  - From: Tom Tromey
- Re: [patch] cleanup: Wunused - amd64
  - From: Aleksandar Ristovski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]