This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 1/9] bp_location.source_file -> bp_location.symtab
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> On Fri, 18 Jan 2013 13:59:23 +0100, Joel Brobecker wrote:
>> > - /* Source file name of this address. */
>> > + /* Source file name which was used to place this location. */
>> >
>> > - char *source_file;
>> > + struct symtab *symtab;
>> > };
Joel> One thing, though. Why preserve "file name" in the comment, since
Joel> this no longer is a filename?
Jan> But it is currently used only for the filename.
I think when I run across that comment again in a year, I will assume
somebody forgot to fix it. How about something like
/* Symtab which was used to place this location. This is used
to find the corresponding source file name. */
Tom