This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 5/9] New option 'set filename-display' [resent]


On Mon, 21 Jan 2013 20:01:54 +0100, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> this part is mostly unchanged, just it is no longer under "set
> Jan> backtrace ...".
> 
> Jan> +  add_setshow_enum_cmd ("filename-display", class_obscure,
> 
> Maybe class_files?  I am not sure.

Moved it under class_files but I do not see any effect.  Filed a PR:
	set/show commands ignore their class
	http://sourceware.org/bugzilla/show_bug.cgi?id=15047


> Jan> +standard_testfile
> Jan> +set executable ${testfile}
> Jan> +set binfile ${objdir}/${subdir}/${executable}
> Jan> +set srcfile ${testfile}.c
> Jan> +set asmsrcfile ${objdir}/${subdir}/${testfile}asm.S
> Jan> +set asmobjfile ${objdir}/${subdir}/${testfile}asm.o
> Jan> +set srcabsdir ${objdir}/${subdir}/${testfile}.d
> 
> I'd prefer standard_output_file rather than direct uses of
> $objdir/$subdir.

Fixed.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]