This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 2/9] Code cleanup: Drop IS_ABSOLUTE_PATH checks

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> 	Code cleanup.
Jan> 	* breakpoint.c (clear_command): Remove variable is_abs, unify the
Jan> 	call of filename_cmp with compare_filenames_for_search.
[...]

Jan>      if (full_path != NULL)
Jan>        {
Jan> +	gdb_assert (IS_ABSOLUTE_PATH (full_path));
Jan> +	gdb_assert (IS_ABSOLUTE_PATH (name));

I wonder if these can really never trigger.

I think under some obscure conditions, xfullpath can return a relative
path, since gdb_realpath can.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]