This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't check PST is NULL in read_symtab

On 01/12/2013 02:44 AM, Joel Brobecker wrote: 
>(It'd be even better for grepability/readability if the implementations
>and hook name agreed, like:
>
>- result->read_symtab = dbx_psymtab_to_symtab;
>+ result->read_symtab = dbx_read_symtab;
>
>or
>
>- result->read_symtab = dbx_psymtab_to_symtab;
>+ result->psymtab_to_symtab = dbx_psymtab_to_symtab;

Agree as well.  I don't mind making these two changes after Yao's
commit goes it (unless Yao wants to take care of it, I don't mean
to cut in).

I'll take care of this in a separate patch.

--
Yao (éå)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]