This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Remove pre_expand_symtabs_matching quick_symbol_functions API

On 01/09/2013 02:52 PM, Tom Tromey wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
> 
> Pedro> Do we still support those index versions?  If so, do we need
> Pedro> to make this conditional?
> 
> Doug> It would be good for another pair of eyes to study the new
> Doug> dw2_lookup_symbol.  I believe it handles this case: After
> Doug> expanding the symtab for a tentative match the symbol is looked up
> Doug> with its attributes and only if that matches is the symbol
> Doug> returned.
> 
> That was my understanding as well.
> 
> Doug> So, yeah, ultimately it's not clear to me if the
> Doug> pre-expand-symtabs-matching version was ever needed.  Another pair of
> Doug> eyes would be welcome.
> 
> Yeah, it seems not.  It must have been an oversight on my part.

Thanks guys.  FAOD, I'm satisfied.

-- 
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]