This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb: x86: fix x32 builds with inline asm


On Tue, 08 Jan 2013 16:52:34 +0100, Mike Frysinger wrote:
> On Tuesday 08 January 2013 10:36:11 H.J. Lu wrote:
> > I think we should keep
> > 
> > #else
> > # error "!__i386__ && !__x86_64__"
> > #endif
> 
> that #else case is currently impossible to hit because the whole func is 
> protected by:
> #if defined __i386__ || defined __x86_64__
> 
> i'm guessing the #else was there only to make sure that some asm test was 
> performed, but since there is no conditional asm, that's no longer an issue

I agree and I do not mind either way.


Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]