This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add extern of output_command to utils.h
- From: Hui Zhu <teawater at gmail dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Fri, 4 Jan 2013 17:03:34 +0800
- Subject: Re: [PATCH] Add extern of output_command to utils.h
- References: <CANFwon27w-6+73nUvm-RYip2Ku8JcGRkVzJVwNrWOzsij6ES8A@mail.gmail.com> <87d2xm0wrs.fsf@fleche.redhat.com>
On Fri, Jan 4, 2013 at 5:41 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
>
> Hui> * tracepoint.c: Remove extern of function output_command.
> Hui> * utils.h (output_command): New extern.
>
> I appreciate you doing this, but utils.h seems like a weird place to put
> this.
>
> I don't know of a better place but I suppose if I were doing it, I would
> look for a header that, ideally, is both printing-related and already
> has some _command declarations in it.
>
> Tom
Hi Tom,
What about add this extern to valprint.h that is included by printcmd.c?
Thanks,
Hui