This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 5/5] AArch64 GDB and GDBSERVER Port V2
- From: Tom Tromey <tromey at redhat dot com>
- To: Marcus Shawcroft <marcus dot shawcroft at arm dot com>
- Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 03 Jan 2013 13:39:30 -0700
- Subject: Re: [PATCH 5/5] AArch64 GDB and GDBSERVER Port V2
- References: <50AD032A.3060500@arm.com>
>>>>> "Marcus" == Marcus Shawcroft <marcus.shawcroft@arm.com> writes:
Marcus> This patch contains the aarch64-linux port of GDBSERVER.
Thanks.
I'm not a good person to review the main part of the patch.
I did have a couple things though.
Marcus> * linux-low.c: For various 'ptrace' calls, cast '0's as the 3rd
Marcus> and 4th arguments to PTRACE_ARG3_TYPE and PTRACE_ARG4_TYPE
Marcus> respectively.
Why is this needed? It seems like it shouldn't be.
Marcus> +aarch64.o : aarch64.c $(regdef_h)
I don't think this is needed any more.
Marcus> +aarch64-without-fpu.o : aarch64-without-fpu.c $(regdef_h)
Likewise.
Marcus> reg-arm.o : reg-arm.c $(regdef_h)
Likewise.
Tom