This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA/OBVIOUS?] ui_file_new function missing "extern" in header.
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Jan Kratochvil'" <jan dot kratochvil at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Sat, 22 Dec 2012 19:57:22 +0100
- Subject: RE: [RFA/OBVIOUS?] ui_file_new function missing "extern" in header.
- References: <001801cddcfa$a93cef10$fbb6cd30$@muller@ics-cnrs.unistra.fr> <20121218084715.GC8054@host2.jankratochvil.net>
> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Jan Kratochvil
> Envoyé?: mardi 18 décembre 2012 09:47
> À?: Pierre Muller
> Cc?: gdb-patches@sourceware.org
> Objet?: Re: [RFA/OBVIOUS?] ui_file_new function missing "extern" in
header.
>
> On Tue, 18 Dec 2012 09:35:39 +0100, Pierre Muller wrote:
> > i.e. shouldn't all functions declared in headers
> > have the extern modifier?
> > Is this mandatory?
> > It doesn't see to change anything in practice, but to me,
> > it seems like good practice...
>
> I agree, it does not change anything. I agree it is probably GNU Coding
> Standards do not talk about it so it could be added to
> gdb/doc/gdbint.texinfo
> "Coding Standards".
>
> I am OK with such kind of changes as obvious ones after updating
> gdbint.texinfo.
>
OK, thus after change to gdbint.texinfo,
I committed this patch as obvious in:
http://sourceware.org/ml/gdb-cvs/2012-12/msg00175.html
I modified the submitted patch to correctly align the parameters of
the following lines, as you suggested.
Thanks Jan,
Pierre Muller